SILGen: Use lowered function type parameters in objc-to-swift thunks for initializers. #84143
+30
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
…for initializers. Fixes a regression caused by the `self` declaration being given a `DynamicSelfType` even though the formal type of the enclosing function sometimes still uses the concrete base class type. Fixes swiftlang#83876 | rdar://158956768.
jckarter
force-pushed
the
protocol-objc-class-dyn-self-mismatch
branch
from
be2a5e2 to
4f1e895
Compare
|
@swift-ci Please test |
|
@swift-ci Please test macOS |
|
@swift-ci Please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression caused by the
selfdeclaration being given aDynamicSelfTypeeven though the formal type of the enclosing function sometimes still uses the concrete base class type.Fixes #83876 | rdar://158956768.