Upgrade to Ninja 1.13 for main, rebranch and next #84172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses rdar://126297330
edymtt
requested review from
etcwilde,
justice-adams-apple and
shahmishal
and removed request for
shahmishal
|
@swift-ci please smoke test |
shahmishal
approved these changes
Sep 9, 2025
|
@etcwilde wasn't there some rare issue that we had observed a few instances of with the 1.13 release? |
|
It was with 1.12.x. I've been living on 1.13.1 for a few months now and haven't seen issues, but I'd like confirmation that it has been tested by a few others before we bump the version for everyone. 1.12.x had a few issues that were fixed in 1.13.x that may be related:
Basically, there was an out-of-bounds access in the ninja dependency graph tracking file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses rdar://126297330