Skip to content

AST: Avoid covered switches over Clang::FeatureAvailKind #84189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2025
Merged

AST: Avoid covered switches over Clang::FeatureAvailKind #84189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions lib/AST/AvailabilityDomain.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,14 @@ using namespace swift;
CustomAvailabilityDomain::Kind
getCustomDomainKind(clang::FeatureAvailKind featureAvailKind) {
switch (featureAvailKind) {
case clang::FeatureAvailKind::None:
llvm_unreachable("unexpected kind");
case clang::FeatureAvailKind::Available:
return CustomAvailabilityDomain::Kind::Enabled;
case clang::FeatureAvailKind::Unavailable:
return CustomAvailabilityDomain::Kind::Disabled;
case clang::FeatureAvailKind::Dynamic:
return CustomAvailabilityDomain::Kind::Dynamic;
default:
llvm::report_fatal_error("unexpected kind");
}
}

Expand All @@ -52,8 +52,15 @@ customDomainForClangDecl(ValueDecl *decl) {
if (featureInfo.first.empty())
return nullptr;

if (featureInfo.second.Kind == clang::FeatureAvailKind::None)
// Check that the domain has a supported availability kind.
switch (featureInfo.second.Kind) {
case clang::FeatureAvailKind::Available:
case clang::FeatureAvailKind::Unavailable:
case clang::FeatureAvailKind::Dynamic:
break;
default:
return nullptr;
}

auto &ctx = decl->getASTContext();
FuncDecl *predicate = nullptr;
Expand Down