🍒 [demangling] make printRoot virtual #84197
Merged
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation:
This patch makes the
NodePrinter::printRoot
method virtual in order to allow for an NFC patch to be merged inswiftlang/llvm-project
([NFC][lldb] de duplicate TrackingNodePrinter finalize logic llvm-project#11352).Scope:
This change impacts the Swift demangler.
Issues:
Original PRs:
Risk:
Low, this patch only makes a method
virtual
, it's pretty much NFC.Testing:
Built and tested at desk on macOS.
Reviewers: