RequirementMachine: Fix crash-on-invalid with concrete type requirements involving packs #84209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
…nts involving packs We would crash in some cases, or produce a slightly misleading diagnostic about same-element requirements, which are related but not quite the same. In the fullness of time, we should figure out this corner of the language. Until then, add a new diagnostic since this is really about same-type requirements between concrete types and packs. Fixes rdar://159790557.
slavapestov
force-pushed
the
fix-rdar159790557
branch
from
d5234dc to
0507b02
Compare
slavapestov
requested review from
CodaFi,
bnbarham,
hamishknight and
rintaro
as code owners
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would crash in some cases, or produce a slightly misleading diagnostic about same-element requirements, which are related but not quite the same.
In the fullness of time, we should figure out this corner of the language. Until then, add a new diagnostic since this is really about same-type requirements between concrete types and packs.
Fixes rdar://159790557.