[cxx-interop] Fix a crash when calling std::any_cast from Swift
#84223
+35
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egorzhdan
requested review from
Xazax-hun,
beccadax,
fahadnayyar,
hnrklssn,
ian-twilightcoder,
j-hui and
susmonteiro
as code owners
|
This relies on #83752. |
Xazax-hun
approved these changes
Sep 11, 2025
egorzhdan
force-pushed
the
egorzhdan/crash-any-cast
branch
from
23279b3 to
f6e9964
Compare
j-hui
approved these changes
Oct 3, 2025
egorzhdan
force-pushed
the
egorzhdan/crash-any-cast
branch
from
f6e9964 to
189e461
Compare
|
@swift-ci please smoke test |
egorzhdan
force-pushed
the
egorzhdan/crash-any-cast
branch
from
189e461 to
8f0aef2
Compare
|
@swift-ci please smoke test |
|
This is the overload that Swift picks and is able to use. Microsoft STL, however, does not have this overload. The overloads there return |
In libc++, `std::any_cast` is declared as a friend function of `std::any`. ClangImporter was not correctly handling friend functions declared within structs within namespaces correctly. rdar://147261941
egorzhdan
force-pushed
the
egorzhdan/crash-any-cast
branch
from
8f0aef2 to
18c5e23
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test Windows |
Xazax-hun
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In libc++,
std::any_castis declared as a friend function ofstd::any.ClangImporter was not correctly handling friend functions declared within structs within namespaces correctly.
rdar://147261941