[windows] create a Windows specific Debug/basic.swift test #84234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian-prantl
requested changes
Sep 11, 2025
test/DebugInfo/basic.swift
Outdated
| // NDEBUG-NOT: DICompileUnit | ||
| // NDEBUG-NOT: DIModule | ||
| // NDEBUG-NOT: DISubroutineType | ||
| // NDEBUG-NOT: DILocalVariable |
There was a problem hiding this comment.
Thanks! I think we need to be both more precise in the test expectations and in documenting them.
Can you make sure that the test
- expects precisely 2 (non-skeleton) DICompileUnits when the target is windows
- expects 0 DICompileUnit when the target is Darwin/linux/...
- documents why Windows is expected to have a DICompileUnit at -gnone ?
There was a problem hiding this comment.
non-skeleton == no dwoId
There was a problem hiding this comment.
I was able to implement such tests. I have updated the description of the PR. The check only tests for exactly 1 (non-skeleton) DICompileUnit when targeting Windows, not 2.
charles-zablit
force-pushed
the
charles-zablit/windows/fix-debuginfo-basic-test-failures
branch
from
09e6548 to
68b3b53
Compare
charles-zablit
changed the title
adrian-prantl
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch splits up the
basic.swifttest into 3 files:basic.swiftfor macOS/linux basic testing: checking if we respect-gnoneor not.basic_windows.swiftfor windows basic testing: do we always emit basic debug information, even withgnone(Since [CodeGen][COFF] Always emit CodeView compiler info on Windows targets llvm/llvm-project#142970 we are always emitting minimal debug information on Windows. This brokeDebugInfo/basic.swift.)advanced.swiftfor all platforms, checking if we are emitting more advanced debug information correctly.basic.swiftandadvanced.swiftonly contain NFC changes, as this change only splits them into 2 files.