[cxx-interop] Refactor copyability out of CxxRecordSemantics #84237
Conversation
susmonteiro
requested review from
Xazax-hun,
beccadax,
egorzhdan,
ian-twilightcoder,
j-hui and
zoecarver
as code owners
|
@swift-ci please smoke test |
lib/ClangImporter/ClangImporter.cpp
Outdated
| } | ||
|
|
||
| llvm_unreachable("Could not classify C++ type."); | ||
| return CxxRecordSemanticsKind::Owned; |
There was a problem hiding this comment.
I think Owned might not be the right default here. Owned means that it cannot dangle. Maybe we need to introduce a placeholder here, like Value?
| }; | ||
|
|
||
| enum class CxxRecordSemanticsKind { | ||
| Trivial, |
There was a problem hiding this comment.
I am a bit conflicted what to do with Trivial. Do you know what do we use this for? Because I think this might be more of a description of how the class is being copied/moved, passed around as an implementation detail rather than a semantic property.
There was a problem hiding this comment.
Yeah, I wonder if we can replace Trivial with Value to indicate a value type.
There was a problem hiding this comment.
So we would replace both Trivial and Owned with Value?
The only place we use this distinction is in SwiftDeclSynthesizer::findExplicitDestroy, when we emit a diagnostic for an illegal destroy operation. But I think I can work around that
susmonteiro
force-pushed
the
susmonteiro/cxxrecord-semantics
branch
2 times, most recently
from
382c581 to
3d7d38c
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test windows |
susmonteiro
force-pushed
the
susmonteiro/cxxrecord-semantics
branch
from
3d7d38c to
2640c71
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test windows |
3 participants
CxxRecordSemanticsdetermines how C++ APIs are imported to Swift, e.g., as owned, reference or iterator types. Since this is orthogonal to importing a type as copyable or move-only, we separateCxxRecordSemanticsfromCxxValueSemantics.