Sema: Narrow fix to allow @_spi_available in extensions
#84238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
tshortli
approved these changes
Sep 11, 2025
tshortli
reviewed
Sep 11, 2025
| // is currently too permissive. It allows SPI use in SPI available which | ||
| // can break swiftinterfaces. The SPI availability logic likely need to be | ||
| // separated from normal SPI and treated more like availability. | ||
| auto ext = dyn_cast_or_null<ExtensionDecl>(where.getDeclContext()); |
There was a problem hiding this comment.
This won't handle a case like this:
@_spi_available(...)
public struct Outer {
public struct Inner {
}
}
extension Outer.Inner {
// ...
}
It's probably not worth addressing now, though. We should aim to support that with a more holistic fix though.
There was a problem hiding this comment.
Right, we'd need to properly propagate the @_spi_available-ness across contexts. That will need a wider fix as the current mechanism for it is mixed in with the normal SPI and probably shouldn't be.
|
@swift-ci Please smoke test Windows |
Allow referencing an `@_spi_available` decl in extensions to `@_spi_available` types. This is a narrow fix as it should really be handled as part of the context check but that check is currently too permissive. Fow now let's narrowly allow legal code. And then we should look at revisiting the SPI availability logic, separate it from normal SPI and treat more like availability. Adding a test comparing the behavior of `@_spi` with `@_spi_available` to document the current implementation. rdar://159292698
xymus
force-pushed
the
spi-avail-in-ext
branch
from
56d73df to
1adbe37
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow referencing an
@_spi_availabledecl in extensions to@_spi_availabletypes. This is a narrow fix as it should really be handled as part of the context check but that check is currently too permissive.Fow now let's narrowly allow legal code. And then we should look at revisiting the SPI availability logic, separate it from normal SPI and treat more like availability.
Adding a test comparing the behavior of
@_spiwith@_spi_availableto document the current implementation.rdar://159292698