Skip to content

Remove a retain-release pair from -count for bridged arrays #84247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2025
Merged

Remove a retain-release pair from -count for bridged arrays #84247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions stdlib/public/core/ContiguousArrayBuffer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ internal final class _ContiguousArrayStorage<

#if _runtime(_ObjC)

@_effects(releasenone)
internal final override func withUnsafeBufferOfObjects<R>(
_ body: (UnsafeBufferPointer<AnyObject>) throws -> R
) rethrows -> R {
Expand Down
6 changes: 5 additions & 1 deletion stdlib/public/core/SwiftNativeNSArray.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ internal class __SwiftNativeNSArrayWithContiguousStorage
deinit {}

// Operate on our contiguous storage
@_effects(releasenone)
internal func withUnsafeBufferOfObjects<R>(
_ body: (UnsafeBufferPointer<AnyObject>) throws -> R
) rethrows -> R {
Expand Down Expand Up @@ -379,6 +380,7 @@ extension __SwiftNativeNSArrayWithContiguousStorage {
_destroyBridgedStorage(_heapBufferBridged)
}

@_effects(releasenone)
internal override func withUnsafeBufferOfObjects<R>(
_ body: (UnsafeBufferPointer<AnyObject>) throws -> R
) rethrows -> R {
Expand Down Expand Up @@ -438,7 +440,8 @@ extension __SwiftNativeNSArrayWithContiguousStorage {
internal final class __SwiftDeferredStaticNSArray<Element>
: __SwiftDeferredNSArray {

internal override func withUnsafeBufferOfObjects<R>(
@_effects(releasenone)
final internal override func withUnsafeBufferOfObjects<R>(
_ body: (UnsafeBufferPointer<AnyObject>) throws -> R
) rethrows -> R {
while true {
Expand Down Expand Up @@ -526,6 +529,7 @@ internal class __ContiguousArrayStorageBase
}

#if _runtime(_ObjC)
@_effects(releasenone)
internal override func withUnsafeBufferOfObjects<R>(
_ body: (UnsafeBufferPointer<AnyObject>) throws -> R
) rethrows -> R {
Expand Down