[6.2][Distributed] Allow disabling SerializationRequirement by using Any #84252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should be possible to disable SerializationRequirement by assigning Any to it. This effectively disables the checking, since any type conforms to that. Previously we would crash trying to check for this conformance; or rather, emitting diagnostics about un-necessary casts then encountering incomplete types in CSDiagnostics. Avoiding the cast entirely sounds like a good solution here. resolves rdar://159285863 [Distributed] Simplify checking for Any type Harden diagnoseForcedCastExpr for lack of cast-to type
ktoso
force-pushed
the
pick-allow-any-serialization-requirement
branch
from
202cec0 to
7842a46
Compare
|
@swift-ci please test |
ktoso
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: It is possible to customize the SerializationRequirement that DistributedActorSystem enforces on all parameters/return types. When this was set to
Any, which can be useful for some special in memory transports, the compiler would emit incorrect code and cause a crash due to another bug null-pointer-dereferencing a type while emitting a diagnostic.This PR resolves both the issue in the diagnostic emitting, as well as the underlying issue -- which was an un-necessary cast to
as Any.Typewhich then would result in emitting an error diagnostic.Scope/Impact: Specifically actor systems which use Any as the serialization requirement. They would previously crash the compiler, and with this fix can work correctly.
Risk: Low, specific to Any using DistributedActorSystems. Has no impact on other types. The diagnostic fix just avoids null pointers.
Testing: Added test to exercise the problem.
Reviewed by: @xedin
Original PR: #84119
Radar: resolves rdar://159285863