[Frontend] Only enable request reference tracking when needed #84265
+29
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The request evaluator is no longer new, and we've since implemented per-request caching.
Short-circuit the logic here early to avoid the dependency logic if recording is disabled.
Only enable when we have a reference dependency output, or are validating dependencies or collecting statistics. This avoids enabling for SourceKit.
…ile` Add an assert to ensure we don't run into cases where we expect dependency tracking to be enabled but it isn't.
hamishknight
requested review from
CodaFi,
artemcm,
slavapestov and
tshortli
as code owners
|
@swift-ci please test |
|
@swift-ci please SourceKit stress test |
slavapestov
approved these changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only enable when we have a reference dependency output, or are validating dependencies or collecting statistics. This avoids enabling for SourceKit.