[CS] Bail from conjunction for non-zero SK_Hole
#84279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
requested review from
bnbarham,
rintaro,
hborla and
xedin
as code owners
Make sure we record a fix here to ensure we don't try to do CSApply with holes.
Since we can run CSGen multiple times, we need to guard the emission of the note on whether the TypeRepr was already marked invalid (i.e whether we already emitted a diagnostic for it).
xedin
reviewed
Sep 15, 2025
hamishknight
force-pushed
the
preserve-fatal-score
branch
from
7fc5023 to
9387793
Compare
hamishknight
changed the title
SK_Hole
xedin
approved these changes
Sep 15, 2025
hamishknight
force-pushed
the
preserve-fatal-score
branch
from
9387793 to
61394ec
Compare
Previously we would only do this for `SK_Fix`, do the same for `SK_Hole` since otherwise the score clearing logic for the conjunction could result in losing the hole score.
hamishknight
force-pushed
the
preserve-fatal-score
branch
from
61394ec to
63d63d8
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would only do this for
SK_Fix, do the same forSK_Holesince otherwise the score clearing logic for the conjunction could result in losing the hole score.