[6.2.0][cxx-interop] Do not consider function types fragile #84284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explanationion: Function pointer types wee always considered fragile in C++ mode, this manifested as a regression when interfacing with glibc. Issues: rdar://159184118 Original PRs: swiftlang#84040 Risk: Low, this only removes a spurious error for library evolution. Testing: Added a compiler test. Reviewers: @egorzhdan
xtremekforever
changed the title
Xazax-hun
approved these changes
Sep 15, 2025
|
LG, but I am afraid that it might be too late to merge anything to 6.2.0 at this point. But the branch managers can tell for sure. |
|
@DougGregor or @shahmishal, please let us know what you think. @swift-ci test |
|
Heh, I figured the recent 6.1.3 release meant 6.2 would be delayed, guess not. |
|
Yeah its too bad! Ive noted this issue for the armv6 and armv7 builds for 6.2 today, but it will be fixed in 6.2.1 anyways.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a copy from @Xazax-hun's PR #84164 but for 6.2.0. I propose this to avoid regressing the 6.2.0 release since this fix is already included in release/6.2 and release/6.2.1. It fixes the following issue outlined here: #83915.
Explanation: Function pointer types wee always considered fragile in C++ mode, this manifested as a regression when interfacing with glibc.
Issues: rdar://159184118
Original PRs: #84040
Risk: Low, this only removes a spurious error for library evolution.
Testing: Added a compiler test.
Reviewers: @egorzhdan