[6.2][cxx-interop] Handle Unowned values in implicit value ctors #84291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xazax-hun
added
c++ interop
DougGregor
approved these changes
Sep 25, 2025
Xazax-hun
force-pushed
the
handle-unowned-in-impicit-value-init-on-6.2
branch
from
4bb197c to
bd40aac
Compare
…mpicit-value-init [cxx-interop] Handle Unowned values in implicit value ctors
Xazax-hun
force-pushed
the
handle-unowned-in-impicit-value-init-on-6.2
branch
from
bd40aac to
9e1b104
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Implicit value constructors did not account for unowned ownership resulting in unbalanced refcounts and use after free errors. This PR makes sure we +1 the unowned constructor arguments to balance out the ref counts.
Issues: rdar://160232360
Original PRs: #84203
Risk: Low, the fix is narrow to implicit value ctors taking foreign reference types and this scenario was broken before the patch.
Testing: Added a compiler test.
Reviewers: @egorzhdan, @jckarter