Add swift-markdown to SourceKit-LSP Windows build #84302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you provide size consequences for this change. I think that we might need to modify the installer-scripts and the build to use dynamic linking to avoid an unnecessary file size increase due to this change. |
|
@compnerd Can we perform such analysis on CI? I don't currently have a Windows machine (and getting one to build Swift from scratch would probably be a hassle). If so, I'd appreciate your guidance on how we can do that. 🙏🏼 |
|
I'm not sure of a good way to do this on CI - changes to the build really should be done locally. I suppose you could build the installer, install the .NET runtime and use the nuget package to get WiX and try to run WiX on .NET Core to decompile the installer. |
a7medev
force-pushed
the
build/add-swift-markdown-to-sourcekit-lsp-cmake
branch
from
b7e7b5c to
65dcb31
Compare
a7medev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for swiftlang/sourcekit-lsp#2292