ModuleInterface: Print imports with @preconcurrency in swiftinterface files #84311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… files. When a module has been imported `@preconcurrency` in source, when it is printed in a `swiftinterface` file it should be printed along with the attribute to ensure that type checking of the module's public declarations behaves consistently. This fix is a little unsatisfying because it adds another a linear scan over all imports in the source for each printed import. This should be improved, but it can be done later. Resolves rdar://136857313.
tshortli
requested review from
artemcm,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
|
swiftlang/swift-foundation#1510 @swift-ci please smoke test |
|
swiftlang/swift-foundation#1512 @swift-ci please smoke test Windows |
xedin
approved these changes
Sep 16, 2025
xymus
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a module has been imported
@preconcurrencyin source, when it is printed in aswiftinterfacefile it should be printed along with the attribute to ensure that type checking of the module's public declarations behaves consistently.This fix is a little unsatisfying because it adds another linear scan over all imports in the source for each printed import. This should be improved, but it can be done later.
Resolves rdar://136857313.