Skip to content

Sema: Better prepared overloads, part 2 #84355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 17 commits into from
Closed

Sema: Better prepared overloads, part 2 #84355

wants to merge 17 commits into from

Conversation

slavapestov
Copy link
Contributor

No description provided.

@slavapestov
Sema: Tweak VarDecl concurrency adjustment in getTypeOfReference() to…
3598347 
… look like FuncDecl case
@slavapestov
Sema: Split off getTypeOfReferenceImpl() from getTypeOfReference()
4c1ce3a
@slavapestov
Sema: Remove replacements parameter from getMemberReferenceTypeFromOp…
c93496d 
…enedType()
@slavapestov
Sema: Pass baseObjTy instead of baseRValueTy to adjustFunctionTypeFor…
1f03462 
…Concurrency()
@slavapestov
Sema: Remove duplicate logic for throwing accessor witness matching
cb56b6f 
getTypeOfMemberReference() already opens the accessor's thrown error
type for us.
@slavapestov
Sema: Split off getTypeOfMemberReferenceImpl() from getTypeOfMemberRe…
fffbc32 
…ference()
@slavapestov
Sema: Refactor getTypeOf{Member,}Reference() to take the OverloadChoice
4f5c7f9
@slavapestov
Sema: Don't need to return new baseObjTy from getTypeOfMemberReferenc…
127f012 
…eImpl()
@slavapestov
Sema: Simplify getConcreteReplacementForProtocolSelfType()
d25fbfd
@slavapestov
Sema: Remove replacementsPtr parameter from getTypeOfMemberReference()
9ffab77
@slavapestov
Sema: Rename getTypeOf{Member,}ReferenceImpl() to Pre() and factor ou…
1ea7382 
…t Post() versions
@slavapestov
Sema: Add -solver-{enable,disable}-prepared-overloads frontend flags
00972e0
@slavapestov
Sema: Get prepared overloads working again with the Pre()/Post() split
5a9e50f
@slavapestov
Sema: Replace calls to OverloadChoice constructor with two overloads …
9a04b0a 
…of getDecl()
@slavapestov
Sema: Sink ModuleDecl handling back down into getTypeOfMemberReferenc…
74e92ff 
…ePre/Post()
@slavapestov
Sema: Clean up ConstraintSystem::resolveOverload() a bit
5067221
@slavapestov
Sema: Remove unused variable
00fce05
@slavapestov
Copy link
Contributor Author

@swift-ci Please test

@slavapestov
Copy link
Contributor Author

@swift-ci Please test source compatibility

@slavapestov
Copy link
Contributor Author

@swift-ci Please test Linux

@slavapestov
Copy link
Contributor Author

@swift-ci Please test Windows

@slavapestov
Copy link
Contributor Author

@swift-ci Please test source compatibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AnthonyLatsis AnthonyLatsis Awaiting requested review from AnthonyLatsis AnthonyLatsis will be requested when the pull request is marked ready for review AnthonyLatsis is a code owner

@hborla hborla Awaiting requested review from hborla hborla will be requested when the pull request is marked ready for review hborla is a code owner

@xedin xedin Awaiting requested review from xedin xedin will be requested when the pull request is marked ready for review xedin is a code owner

@artemcm artemcm Awaiting requested review from artemcm artemcm will be requested when the pull request is marked ready for review artemcm is a code owner

@tshortli tshortli Awaiting requested review from tshortli tshortli will be requested when the pull request is marked ready for review tshortli is a code owner

@DougGregor DougGregor Awaiting requested review from DougGregor DougGregor will be requested when the pull request is marked ready for review DougGregor is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@slavapestov