[Embedded] Enable Embedded Swift restrictions diagnostics (as warnings) in embedded builds #84359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s) in embedded builds These restrictions will generally manifest as failures of various forms later in the compiler process. Enable the diagnostics to give earlier feedback to help stay within the bounds of Embedded Swift. Fixes rdar://121205043.
Where we have rethrowing versions of functions that have typed-throws counterparts that are only retained for ABI compatibility, wrap them in `#if !$Embedded` so they aren't compiled into the Embedded version of the standard library. This eliminates warnings about this code, which cannot actually be used with arbitrary errors anyway.
DougGregor
requested review from
a team,
artemcm and
tshortli
as code owners
|
@swift-ci please smoke test |
rauhul
approved these changes
Sep 17, 2025
|
@swift-ci please smoke test Linux |
1 similar comment
|
@swift-ci please smoke test Linux |
|
swiftlang/swift-package-manager#9153 @swift-ci please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These restrictions will generally manifest as failures of various forms later in the compiler process. Enable the diagnostics to give earlier feedback to help stay within the bounds of Embedded Swift.
Practically speaking, this means we'll diagnose uses of untyped throws in Embedded code bases. This is pretty noisy on the Swift standard library when it builds for Embedded Swift, because it's highlighting the various places where we are either compiling in rethrowing backward-compatibility stubs (I've
#if'd out many of these) or we haven't adopted typed throws where we need to.Fixes rdar://121205043.