Reduce surface for command injection in some Python scripts #84371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Namely, in scripts that alter the search paths for dylibs, ensure to invoke `/usr/bin/xcrun` directly to run `dyld_info` and `install_name_tool`, and validate that each argument is a valid path. Addresses rdar://160463033
edymtt
requested review from
al45tair,
etcwilde,
justice-adams-apple and
shahmishal
|
@swift-ci please test |
|
@swift-ci please build toolchain |
|
@swift-ci please smoke test Linux |
|
@swift-ci please test Linux |
|
@swift-ci please test |
|
@swift-ci please build toolchain |
|
@swift-ci please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namely, in scripts that alter the search paths for dylibs, ensure to invoke
/usr/bin/xcrundirectly to rundyld_infoandinstall_name_tool, and validate that each argument is a valid path.Addresses rdar://160463033