Sema: Limit errors on LE importing non-LE modules to SDK modules #84373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xymus
requested review from
hborla,
slavapestov,
xedin and
DougGregor
as code owners
|
@swift-ci Please smoke test |
tshortli
approved these changes
Sep 18, 2025
Limit reporting as an error imports of a non-library-evolution module from a library-evolution enabled module to sources that are part of the SDK. The error also requires having enabled `InternalImportsByDefault`. This should help prevent SDK breaking regressions while loosening the restriction elsewhere. Framework owners can enable `-library-level api` or `spi` to get this check as an error, along with more sanity checks. Other cases remain as a warning. We should look to silence it in some cases or offer a flag to do so. rdar://160414667
xymus
force-pushed
the
le-import-warn
branch
from
1a14a8f to
8b38d29
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit reporting as an error imports of a non-library-evolution module from a library-evolution enabled module to sources that are part of the SDK. The error also requires having enabled
InternalImportsByDefault. This should help prevent SDK breaking regressions while loosening the restriction elsewhere.Framework owners can enable
-library-level apiorspito get this check as an error, along with more sanity checks.Other cases remain as a warning. We should look to silence it in some cases or offer a flag to do so.
Resolves: #84241
rdar://160414667