[Distributed] Avoid redundant conformance to DistributedActor in interfaces #84384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rface files Forgetting to handle DistributedActor next to Actor strikes again: Actors are special that their conformance is implicit and needs not be printed in swift interface files. an actor's Actor conformance was filtered out, however the same logic needs to be applied to DistributedActor, as otherwise there can be redundant conformance errors when validating module interface files. Resolves rdar://160252579
ktoso
requested review from
artemcm,
slavapestov and
tshortli
as code owners
xedin
approved these changes
Sep 19, 2025
|
@swift-ci please smoke test |
tshortli
reviewed
Sep 19, 2025
test/ModuleInterface/distributed_no_redundant_conformance.swift
Outdated
Show resolved
Hide resolved
tshortli
reviewed
Sep 19, 2025
ktoso
force-pushed
the
wip-distributed-red-conf
branch
from
990f5c2 to
1ea4e91
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgetting to handle DistributedActor next to Actor strikes again:
Actors are special that their conformance is implicit and needs not be
printed in swift interface files.
an actor's Actor conformance was filtered out, however the same logic
needs to be applied to DistributedActor, as otherwise there can be
redundant conformance errors when validating module interface files.
Resolves rdar://160252579