Runtimes: provide a dedicated find module for Darwin overlay #84388
+73
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the search is embedded in FindSwiftOverlay, and that prevents linking both Darwin and _Builtin_Float when leveraging the config file generated by the Overlay build system. This would be needed to build the upcoming Runtime modules. Addresses rdar://160774151
edymtt
requested review from
etcwilde,
compnerd and
justice-adams-apple
as code owners
|
@swift-ci please smoke test |
edymtt
added a commit
to edymtt/swift
that referenced
this pull request
Sep 19, 2025
* take the chance to rename the containing folder, as in this context it should be clear we are talking about the Runtime module and not the Swift runtime * this will fail to build for Apple platforms until we land swiftlang#84388 -- to signal this, comment the invocations that would add the dependency on the Darwin overlay Addresses rdar://160774902 Cherry-picked from f65a9ab
edymtt
added a commit
to edymtt/swift
that referenced
this pull request
Sep 19, 2025
* take the chance to rename the containing folder, as in this context it should be clear we are talking about the Runtime module and not the Swift runtime * this will fail to build for Apple platforms until we land swiftlang#84388 -- to signal this, comment the invocations that would add the dependency on the Darwin overlay Addresses rdar://160774902
edymtt
added a commit
to edymtt/swift
that referenced
this pull request
Sep 19, 2025
* take the chance to rename the containing folder, as in this context it should be clear we are talking about the Runtime module and not the Swift runtime * this will fail to build for Apple platforms until we land swiftlang#84388 -- to signal this, comment the invocations that would add the dependency on the Darwin overlay * piggyback a fix to ensure we rebuild always all the external projects in the Supplemental superbuild used in macOS PR testing Addresses rdar://160774902
edymtt
added a commit
to edymtt/swift
that referenced
this pull request
Sep 19, 2025
* take the chance to rename the containing folder, as in this context it should be clear we are talking about the Runtime module and not the Swift runtime * this will fail to build for Apple platforms until we land swiftlang#84388 -- to signal this, comment the invocations that would add the dependency on the Darwin overlay * piggyback a fix to ensure we rebuild always all the external projects in the Supplemental superbuild used in macOS PR testing Addresses rdar://160774902
edymtt
added a commit
to edymtt/swift
that referenced
this pull request
Sep 19, 2025
* take the chance to rename the containing folder, as in this context it should be clear we are talking about the Runtime module and not the Swift runtime * this will fail to build for Apple platforms until we land swiftlang#84388 -- to signal this, comment the invocations that would add the dependency on the Darwin overlay * piggyback a fix to ensure we rebuild always all the external projects in the Supplemental superbuild used in macOS PR testing Addresses rdar://160774902
edymtt
added a commit
to edymtt/swift
that referenced
this pull request
Sep 19, 2025
* take the chance to rename the containing folder, as in this context it should be clear we are talking about the Runtime module and not the Swift runtime * this will fail to build for Apple platforms until we land swiftlang#84388 -- to signal this, comment the invocations that would add the dependency on the Darwin overlay * piggyback a fix to ensure we rebuild always all the external projects in the Supplemental superbuild used in macOS PR testing Addresses rdar://160774902
edymtt
added a commit
to edymtt/swift
that referenced
this pull request
Sep 19, 2025
* take the chance to rename the containing folder, as in this context it should be clear we are talking about the Runtime module and not the Swift runtime * this will fail to build for Apple platforms until we land swiftlang#84388 -- to signal this, comment the invocations that would add the dependency on the Darwin overlay * piggyback a fix to ensure we rebuild always all the external projects in the Supplemental superbuild used in macOS PR testing Addresses rdar://160774902 Cherry-picked from 16b699a
edymtt
added a commit
to edymtt/swift
that referenced
this pull request
Sep 19, 2025
* take the chance to rename the containing folder, as in this context it should be clear we are talking about the Runtime module and not the Swift runtime * this will fail to build for Apple platforms until we land swiftlang#84388 -- to signal this, comment the invocations that would add the dependency on the Darwin overlay * piggyback a fix to ensure we rebuild always all the external projects in the Supplemental superbuild used in macOS PR testing Addresses rdar://160774902
edymtt
added a commit
to edymtt/swift
that referenced
this pull request
Sep 19, 2025
* take the chance to rename the containing folder, as in this context it should be clear we are talking about the Runtime module and not the Swift runtime * this will fail to build for Apple platforms until we land swiftlang#84388 -- to signal this, comment the invocations that would add the dependency on the Darwin overlay * piggyback a fix to ensure we rebuild always all the external projects in the Supplemental superbuild used in macOS PR testing Addresses rdar://160774902
edymtt
deleted the
edymtt/split-find-swiftdarwin-from-find-swiftoverlay
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the search is embedded in FindSwiftOverlay, and that prevents linking both Darwin and _Builtin_Float when leveraging the config file generated by the Overlay build system.
This would be needed to build the upcoming Runtime modules.
Addresses rdar://160774151