sil: provide ability to run CopyPropagation in -Onone #84411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavon
requested review from
eeckstein,
jckarter,
artemcm,
tshortli,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci smoke test |
This does not enable it by default. Use either of the flags: ``` -enable-copy-propagation -enable-copy-propagation=always ``` to enable it in -Onone. The previous frontend flag `-enable-copy-propagation=true` has been renamed to `-enable-copy-propagation=optimizing`, which is currently default. rdar://107610971
kavon
force-pushed
the
copyprop-onone
branch
from
e0b1286 to
4a943d4
Compare
|
@swift-ci smoke test |
|
failing in update-checkout @swift-ci smoke test macos |
eeckstein
reviewed
Sep 22, 2025
| // call-sites, but PerformanceDiagnostics is sensitive to the # of copies. | ||
| // If ManualOwnership is used in the compiler itself, we wouldn't be able | ||
| // to bootstrap the compiler on different platforms with same diagnostics. | ||
| #ifdef SWIFT_ENABLE_SWIFT_IN_SWIFT |
There was a problem hiding this comment.
@kavon this ifdef is not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not enable it by default. Use either of the flags:
to enable it in -Onone. The previous frontend flag
-enable-copy-propagation=truehas been renamed to-enable-copy-propagation=optimizing, which is currently default.rdar://107610971