[AST] Print ErrorType as _
#84426
Merged
[AST] Print ErrorType as _
#84426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
requested review from
hborla,
slavapestov,
xedin,
bnbarham,
rintaro,
ktoso and
tshortli
as code owners
Use the same set of PrintOptions when printing the results for different requests.
Use for a few `dump` methods, generic signature debugging, and enable by default for swift-ide-test.
In preparation for removing UnresolvedType in favor of ErrorType, start printing ErrorType as `_` unless we've enabled debug printing. `<<error type>>` should never be presented to the user, instead `_` now just consistently means "unknown type".
hamishknight
force-pushed
the
wallsocket
branch
2 times, most recently
from
9bb05d3 to
0bfbe98
Compare
|
@swift-ci please test |
ktoso
approved these changes
Sep 22, 2025
|
It's the other way around :) |
|
Yeah the goal here is to remove UnresolvedType and just use ErrorType instead |
|
Ah got it :-) we've been using ErrorType everywhere so nothing to worry about then, thanks! |
xedin
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for removing UnresolvedType in favor of ErrorType, start printing ErrorType as
_unless we've enabled debug printing.<<error type>>should never be presented to the user, instead_now just consistently means "unknown type".