Skip to content

[cxx-interop] Avoid trying to generate module interfaces twice #84435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2025
Merged

[cxx-interop] Avoid trying to generate module interfaces twice #84435

merged 1 commit into from
Oct 7, 2025

Conversation

egorzhdan
Copy link
Contributor

This reverts most of 72050c5, which led to decreased performance of jump-to-definition.

Instead of re-attempting to generate a module interface with C++ interop enabled, Swift should rely on the IDE to pass the correct -cxx-interoperability-mode= value to SourceKit.

rdar://149061322

@egorzhdan egorzhdan added the c++ interop Feature: Interoperability with C++ label Sep 22, 2025
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

j-hui
j-hui approved these changes Sep 22, 2025
View reviewed changes
Copy link
Contributor

@j-hui j-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm wondering: for projects built using, say, SwiftPM or Cmake, how would the IDE/sourcekit-lsp know which interop mode should be used?

@egorzhdan
Copy link
Contributor Author

@j-hui the -cxx-interoperability-mode= would be part of the arguments that the build system passes to the compiler, along with e.g. -target and -swift-version, so SourceKit will be able to pick that up.

@egorzhdan
[cxx-interop] Avoid trying to generate module interfaces twice
a610bcd 
This reverts most of 72050c5, which led to decreased performance of jump-to-definition.

Instead of re-attempting to generate a module interface with C++ interop enabled, Swift should rely on the IDE to pass the correct `-cxx-interoperability-mode=` value to SourceKit.

rdar://149061322
@egorzhdan egorzhdan force-pushed the egorzhdan/do-not-generate-interface-twice branch from 373130a to a610bcd Compare September 22, 2025 17:48
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

@egorzhdan egorzhdan merged commit 62d388a into swiftlang:main Oct 7, 2025
3 checks passed
@egorzhdan egorzhdan deleted the egorzhdan/do-not-generate-interface-twice branch October 7, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xazax-hun Xazax-hun Xazax-hun approved these changes

@j-hui j-hui j-hui approved these changes

@fahadnayyar fahadnayyar fahadnayyar approved these changes

@susmonteiro susmonteiro Awaiting requested review from susmonteiro

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

@hamishknight hamishknight Awaiting requested review from hamishknight hamishknight is a code owner

@rintaro rintaro Awaiting requested review from rintaro rintaro is a code owner

Assignees
No one assigned
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@egorzhdan @Xazax-hun @j-hui @fahadnayyar