lit.cfg: Use raw strings for regex patterns. #84439
Open
+18
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci Please test macOS |
This avoid deprecated/syntax warnings about invalid escape sequences.
The deprecation warnings were off by default but made into
SyntaxWarnings in python 3.12+
For example,
swift/test/lit.cfg:2899: SyntaxWarning: invalid escape sequence '\('
config.substitutions.append(('%target-swift-emit-module-interfaces\(([^)]+),\w*([^)]+)\)',
swift/test/lit.cfg:2901: SyntaxWarning: invalid escape sequence '\('
config.substitutions.append(('%target-swift-emit-module-interface\(([^)]+)\)',
rjmansfield
force-pushed
the
litcfg_regex
branch
from
c81f03a to
b91f88b
Compare
|
@swift-ci please smoke test |
rjmansfield
force-pushed
the
litcfg_regex
branch
from
b91f88b to
57f2b89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoid deprecated/syntax warnings about invalid escape sequences. The deprecation warnings were off by default but made into SyntaxWarnings in python 3.12+.
For example,
swift/test/lit.cfg:2899: SyntaxWarning: invalid escape sequence '('
config.substitutions.append(('%target-swift-emit-module-interfaces(([^)]+),\w*([^)]+))',
swift/test/lit.cfg:2901: SyntaxWarning: invalid escape sequence '('
config.substitutions.append(('%target-swift-emit-module-interface(([^)]+))',