[swift-inspect] Add a mode to search for and dump generic metadata without metadata iteration enabled. #84446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
reviewed
Sep 22, 2025
tools/swift-inspect/Sources/swift-inspect/DarwinRemoteProcess.swift
Outdated
Show resolved
Hide resolved
| if typeref == 0 { return nil } | ||
|
|
||
| let info = swift_reflection_infoForTypeRef(self, typeref) | ||
| let nameableTypes = [ |
There was a problem hiding this comment.
nominalTypes seems like a better name
There was a problem hiding this comment.
You'd think I would have absorbed something from all these years working with compiler engineers.
There was a problem hiding this comment.
To be fair, NASA thoroughly muddied the waters on the meaning of the word “nominal”… (at least, I assume it was them… maybe I'm blaming them unfairly and they got it from Boeing or somewhere…)
mikeash
force-pushed
the
swift-inspect-scan-search
branch
from
f9204a3 to
6fd1452
Compare
|
Updated to address comments. |
mikeash
force-pushed
the
swift-inspect-scan-search
branch
from
6fd1452 to
069b4c8
Compare
compnerd
approved these changes
Sep 23, 2025
|
@swift-ci please test |
|
@swift-ci please test macos platform |
…thout metadata iteration enabled. We scan the target's initial allocation pool, and all 16kB heap allocations. We check each pointer-aligned offset within those areas, and try to read it as Swift metadata and get a name from it. If that fails, quietly move on. It's very unlikely for some random memory to look enough like Swift metadata for this to produce a name, so this works very well to print the generic metadata instantiated in the remote process without requiring `SWIFT_DEBUG_ENABLE_METADATA_ALLOCATION_ITERATION`. rdar://161120936
mikeash
force-pushed
the
swift-inspect-scan-search
branch
from
069b4c8 to
513f5fb
Compare
|
The new symbols need to be added to the ABI tests. |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We scan the target's initial allocation pool, and all 16kB heap allocations. We check each pointer-aligned offset within those areas, and try to read it as Swift metadata and get a name from it. If that fails, quietly move on. It's very unlikely for some random memory to look enough like Swift metadata for this to produce a name, so this works very well to print the generic metadata instantiated in the remote process without requiring
SWIFT_DEBUG_ENABLE_METADATA_ALLOCATION_ITERATION.rdar://161120936