AST/Sema: Diagnose references to permanently enabled availability domains #84454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
requested review from
DougGregor,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
…ains A "permanently enabled" availability domain is one that has been declared always available and is also simultaneously has either an attribute that makes it deprecated or universally unavailable. Emit fix-its that remove (or update) `@available` attributes that restrict availability in a permanently enabled domain. Also, emit warnings about `if #available` queries that always return true because they check a permanently enabled domain. Resolves rdar://157601761.
tshortli
force-pushed
the
deprecated-custom-availability-domain-fix-its
branch
from
5d38e89 to
8a1338d
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A "permanently enabled" availability domain is one that has been declared always available and is also simultaneously has either an attribute that makes it deprecated or universally unavailable.
Emit fix-its that remove (or update)
@availableattributes that restrict availability in a permanently enabled domain. Also, emit warnings aboutif #availablequeries that always return true because they check a permanently enabled domain.Resolves rdar://157601761.