🍒[cxx-interop] Allow retain/release operations to be methods #84462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some foreign reference types such as IUnknown define retain/release operations as methods of the type. Previously Swift only supported retain/release operations as standalone functions. The syntax for member functions would be `SWIFT_SHARED_REFERENCE(.doRetain, .doRelease)`. rdar://160696723 (cherry picked from commit e78ce61)
|
@swift-ci please test |
Xazax-hun
approved these changes
Sep 23, 2025
DougGregor
approved these changes
Sep 23, 2025
Comment on lines
+7888
to
+7897
| if (name.starts_with(".")) { | ||
| // Look for a member of decl instead of a global. | ||
| StringRef memberName = name.drop_front(1); | ||
| if (memberName.empty()) | ||
| return {}; | ||
| auto declName = DeclName(ctx.getIdentifier(memberName)); | ||
| auto allResults = evaluateOrDefault( | ||
| ctx.evaluator, ClangRecordMemberLookup({decl, declName}), {}); | ||
| return SmallVector<ValueDecl *, 1>(allResults.begin(), allResults.end()); | ||
| } |
There was a problem hiding this comment.
Do we also need a spelling for static member functions?
There was a problem hiding this comment.
For now, we are rejecting static member functions in https://github.com/swiftlang/swift/pull/84343/files#diff-d29df7eb941cda5dc4dc36df1f3220fe4468a9b58d4fa8ca251c76337f353589R2805. In future I think it would be reasonable to allow it, possibly with the same leading-dot spelling, once we figure out the correct behavior for static retain/release functions declared in a base type.
|
@swift-ci please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously Swift only supported retain/release operations as standalone functions.
The syntax for member functions would be
SWIFT_SHARED_REFERENCE(.doRetain, .doRelease).