LICM fix missing materializable projection check #84463
Merged
+53
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
eeckstein
reviewed
Sep 23, 2025
| return accessPath.isEqualOrContains(self.operand.value.accessPath) || self.operand.value.accessPath.isEqualOrContains(accessPath) | ||
| // If store is wider than load, it needs to be materializable. | ||
| // Otherwise we won't be able to project it. | ||
| return (accessPath.getProjection(to: self.operand.value.accessPath)?.isMaterializable ?? false) || |
There was a problem hiding this comment.
nitpick: IMO it's more readable to split this complex condition into multiple statements, e.g:
if let path = accessPath.getProjection(to: self.operand.value.accessPath),
// If the accessPath is wider than load, it needs to be materializable.
// Otherwise we won't be able to project it.
path. isMaterializable
{
// The load is narrower than the access path.
return true
}
if self.operand.value.accessPath.isEqualOrContains(accessPath) {
// The load is wider than the access path.
return true
}
return false
MAJKFL
force-pushed
the
fix-licm-missing-earlier-materializable-projection-check
branch
from
a83bb70 to
6788017
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before attempting load splitting, licm needs to check the projection path is actually materializable. By bailing earlier, we ensure wider stores are not sank without the narrower load projection.