ModuleInterface: Don't print @c @implementation functions
#84488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to print the `@c @implementation` functions in swiftinterfaces as clients need only to see the original declaration in the C header. Don't print `@objc @implementation` functions either, but still print simple `@c` and `@objc` functions.
xymus
requested review from
hborla,
slavapestov,
tshortli and
xedin
as code owners
|
@swift-ci Please smoke test |
tshortli
approved these changes
Sep 24, 2025
|
|
||
| // Skip @c @implementation functions along with the attribute. | ||
| if (auto AFD = dyn_cast<AbstractFunctionDecl>(D)) { | ||
| if (options.excludeAttrKind(DeclAttrKind::ObjCImplementation) && |
There was a problem hiding this comment.
I guess DeclAttrKind::ObjCImplementation represents @implementation right? This code makes more sense when you realize that but it feels like ObjCImplementation and isObjCImplementation() should maybe be renamed now that they are not Obj-C specific. Is that planned?
There was a problem hiding this comment.
Right, that's the @implementation attribute. This wasn't exactly in the plans but I'll see what I can do along with this feature becoming official.
|
@swift-ci Please smoke test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to print
@c @implementationfunctions in swiftinterfaces as clients should only see the original declaration in the C header. Ensure we don't print@c @implementationand@objc @implementationfunctions, but still print simple@cand@objcfunctions.