Usability improvements for ManualOwnership (part 3) #84504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were getting an address-based emission for loadable types, if the result of a LoadExpr was explicit-copied. This emission had extra hidden copies that could not be silenced.
ManualOwnership effectively subsumes @_noImplicitCopy, by diagnosing all implicit copies in a function.
These wrappers are detected by the move checking passes, to support the implicit no-implicit-copy check for parameters with ownership specifiers. ManualOwnership already does this kind of checking, and the two passes can interfere with each other, such as intercepting diagnostics that are meant to be emitted by ManualOwnership.
Was mistakenly counting a 'store' as a copying instruction, when it's only a consuming one. SILGen was not handling lvalues that are addresses for loadable types correctly, when emitting a CopyExpr in ManualOwnership.
kavon
requested review from
eeckstein,
hborla,
jckarter,
slavapestov and
xedin
as code owners
|
@swift-ci smoke test |
|
swiftlang/swift-docc#1299 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A continuation atop #84498
New things:
varworks a little better, but there are known issues still.