[Swiftify] Add support for free functions imported as instance methods #84507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hnrklssn
requested review from
Xazax-hun,
beccadax,
egorzhdan,
fahadnayyar,
ian-twilightcoder,
j-hui,
susmonteiro and
zoecarver
as code owners
|
@swift-ci please smoke test |
hnrklssn
force-pushed
the
swiftify-import-as-method
branch
from
628fc8a to
c1bf742
Compare
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
Xazax-hun
approved these changes
Sep 25, 2025
Xazax-hun
reviewed
Sep 25, 2025
|
@swift-ci please smoke test |
4 similar comments
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
Xazax-hun
approved these changes
Sep 26, 2025
| let args: [ExprSyntax] = base.signature.parameterClause.parameters.enumerated() | ||
| .map { (i: Int, param: FunctionParameterSyntax) in | ||
| return pointerArgs[i] ?? ExprSyntax("\(param.name)") | ||
| if let overrideArg = pointerArgs[i] { |
There was a problem hiding this comment.
I wonder if this is a fix we want to backport to 6.2.
There was a problem hiding this comment.
Yeah that's probably a good idea
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
hnrklssn
force-pushed
the
swiftify-import-as-method
branch
from
51c8c99 to
801f900
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
This adds support for attaching safe interop wrappers to functions explicitly imported as instance methods using swift_name. rdar://156288883
While we handled prepending & to MutableSpan parameters, regular parameters that were unchanged during the transformation were not checked for inout-ness.
Since the compiler invokation performing the macro expansion dump redirects its stderr output, any errors are not displayed by default. This is extra problematic for test failures in CI. By performing the compiler invokation with -verify first, errors are shown.
hnrklssn
force-pushed
the
swiftify-import-as-method
branch
from
8c4e699 to
f631365
Compare
|
@swift-ci please smoke test windows platform |
hnrklssn
force-pushed
the
swiftify-import-as-method
branch
from
f631365 to
0c3db50
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test linux |
|
@swift-ci please smoke test macos |
hnrklssn
added a commit
to hnrklssn/swift
that referenced
this pull request
Oct 8, 2025
…ethod [Swiftify] Add support for free functions imported as instance methods (cherry picked from commit ed4f058)
hnrklssn
added a commit
to hnrklssn/swift
that referenced
this pull request
Oct 8, 2025
…ethod [Swiftify] Add support for free functions imported as instance methods (cherry picked from commit ed4f058)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for attaching safe interop wrappers to functions explicitly imported as instance methods using swift_name.
rdar://156288883