AST: Give CustomAvailabilityDomain 8 byte alignment
#84529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`AvailabilityDomain` is a pointer union over `CustomAvailabilityDomain` and an opaque pointer-like 24-bit value, which means the number of spare bits in an `AvailabilityDomain` representation is one fewer than a `CustomAvailabilityDomain` pointer. Other structures in the compiler rely on there being at least 2 spare bits in `AvailabilityDomain`, though, which was not the case when building for a 32 bit architecture. To ensure there are enough spare bits, always align `CustomAvailabilityDomain` to 8 bytes, the same as many AST data structures.
tshortli
requested review from
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
tshortli
changed the title
CustomAvailabilityDomain 8 byte alignment.CustomAvailabilityDomain 8 byte alignment
|
@swift-ci please smoke test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AvailabilityDomainis a pointer union overCustomAvailabilityDomainand an opaque pointer-like 24-bit value, which means the number of spare bits in anAvailabilityDomainrepresentation is one fewer than aCustomAvailabilityDomainpointer. Other structures in the compiler rely on there being at least 2 spare bits inAvailabilityDomain, though, which was not the case when building for a 32 bit architecture. To ensure there are enough spare bits, always alignCustomAvailabilityDomainto 8 bytes, the same as many AST data structures.