Skip to content

Runtimes: ensure that all symbols are fully resolved on Android #84538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2025
Merged

Runtimes: ensure that all symbols are fully resolved on Android #84538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Runtimes/Core/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ add_compile_options(
# a compromise, treat all linker warnings as errors.
add_link_options($<$<PLATFORM_ID:Windows>:LINKER:/WX>)
# Ensure all symbols are fully resolved on Linux
add_link_options($<$<PLATFORM_ID:Linux>:LINKER:-z,defs>)
add_link_options($<$<PLATFORM_ID:Android,Linux>:LINKER:-z,defs>)

add_compile_options(
$<$<COMPILE_LANGUAGE:Swift>:-explicit-module-build>
Expand Down
2 changes: 1 addition & 1 deletion Runtimes/Overlay/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ include(ExperimentalFeatures)
# a compromise, treat all linker warnings as errors.
add_link_options($<$<PLATFORM_ID:Windows>:LINKER:/WX>)
# Ensure all symbols are fully resolved on Linux
add_link_options($<$<PLATFORM_ID:Linux>:LINKER:-z,defs>)
add_link_options($<$<PLATFORM_ID:Android,Linux>:LINKER:-z,defs>)

include(ExperimentalFeatures)

Expand Down
2 changes: 1 addition & 1 deletion Runtimes/Supplemental/Differentiation/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ add_compile_options(
# `_fatalErrorForwardModeDifferentiationDisabled`
# add_link_options($<$<PLATFORM_ID:Windows>:LINKER:/WX>)
# Ensure all symbols are fully resolved on Linux
add_link_options($<$<PLATFORM_ID:Linux>:LINKER:-z,defs>)
add_link_options($<$<PLATFORM_ID:Android,Linux>:LINKER:-z,defs>)

if(SwiftDifferentiation_ENABLE_VECTOR_TYPES)
gyb_expand(SIMDDifferentiation.swift.gyb SIMDDifferentiation.swift)
Expand Down
2 changes: 1 addition & 1 deletion Runtimes/Supplemental/Distributed/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ add_compile_options(
# a compromise, treat all linker warnings as errors.
add_link_options($<$<PLATFORM_ID:Windows>:LINKER:/WX>)
# Ensure all symbols are fully resolved on Linux
add_link_options($<$<PLATFORM_ID:Linux>:LINKER:-z,defs>)
add_link_options($<$<PLATFORM_ID:Android,Linux>:LINKER:-z,defs>)

add_library(swiftDistributed
DistributedActor.cpp
Expand Down
2 changes: 1 addition & 1 deletion Runtimes/Supplemental/Observation/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ add_compile_options(
# a compromise, treat all linker warnings as errors.
add_link_options($<$<PLATFORM_ID:Windows>:LINKER:/WX>)
# Ensure all symbols are fully resolved on Linux
add_link_options($<$<PLATFORM_ID:Linux>:LINKER:-z,defs>)
add_link_options($<$<PLATFORM_ID:Android,Linux>:LINKER:-z,defs>)

add_library(swiftObservation
Sources/Observation/Locking.swift
Expand Down
2 changes: 1 addition & 1 deletion Runtimes/Supplemental/StringProcessing/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ add_compile_options(
# a compromise, treat all linker warnings as errors.
add_link_options($<$<PLATFORM_ID:Windows>:LINKER:/WX>)
# Ensure all symbols are fully resolved on Linux
add_link_options($<$<PLATFORM_ID:Linux>:LINKER:-z,defs>)
add_link_options($<$<PLATFORM_ID:Android,Linux>:LINKER:-z,defs>)

add_subdirectory(_RegexParser)
add_subdirectory(_StringProcessing)
Expand Down
2 changes: 1 addition & 1 deletion Runtimes/Supplemental/Synchronization/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ add_compile_options(
# a compromise, treat all linker warnings as errors.
add_link_options($<$<PLATFORM_ID:Windows>:LINKER:/WX>)
# Ensure all symbols are fully resolved on Linux
add_link_options($<$<PLATFORM_ID:Linux>:LINKER:-z,defs>)
add_link_options($<$<PLATFORM_ID:Android,Linux>:LINKER:-z,defs>)

gyb_expand(Atomics/AtomicIntegers.swift.gyb Atomics/AtomicIntegers.swift)
gyb_expand(Atomics/AtomicStorage.swift.gyb Atomics/AtomicStorage.swift)
Expand Down
2 changes: 1 addition & 1 deletion Runtimes/Supplemental/Volatile/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ add_compile_options(
# a compromise, treat all linker warnings as errors.
add_link_options($<$<PLATFORM_ID:Windows>:LINKER:/WX>)
# Ensure all symbols are fully resolved on Linux
add_link_options($<$<PLATFORM_ID:Linux>:LINKER:-z,defs>)
add_link_options($<$<PLATFORM_ID:Android,Linux>:LINKER:-z,defs>)

add_library(swift_Volatile
Volatile.swift)
Expand Down