[Sema] Remove a couple uses of UnresolvedType #84556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…laceholders` Now that ErrorType prints as `_`, we can use that instead of UnresolvedType here since the original type is only really used for type printing and debugging.
Return PlaceholderType instead of UnresolvedType, meaning we now treat the following cases the same: ``` let x1 = foo let x2: _ = foo ```
These shouldn't be necessary anymore, we should be able to handle ErrorType patterns.
These cases should no longer be reachable.
hamishknight
requested review from
hborla,
slavapestov,
xedin and
tshortli
as code owners
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
hamishknight
commented
Sep 29, 2025
| // Take a look at the conversion type to check to make sure it is sensible. | ||
| if (auto type = contextualInfo.getType()) { | ||
| // If we're asked to convert to an UnresolvedType, then ignore the request. | ||
| // This happens when CSDiags nukes a type. |
There was a problem hiding this comment.
This is actually the last reference to CSDiag outside of the test suite
xedin
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid producing it in
PatternTypeRequestandreplacingTypeVariablesAndPlaceholders, and remove some unnecessaryhasErrorandhasUnresolvedTypechecks.