Skip to content

🍒[cxx-interop] Fix lifetime-operation-methods.swift #84562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 30, 2025
Merged

🍒[cxx-interop] Fix lifetime-operation-methods.swift #84562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2610a41
[cxx-interop] Add missing `// REQUIRES: executable_test`
egorzhdan Sep 25, 2025
6fc3dfb
[cxx-interop] Fix lifetime-operation-methods.swift in optimized mode
egorzhdan Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions test/Interop/Cxx/foreign-reference/Inputs/lifetime-operation-methods.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,18 +62,18 @@ struct CRTPDerived : CRTPBase<CRTPDerived> {
struct VirtualRetainRelease {
int value;
mutable int refCount = 1;
mutable bool calledBase = false;
VirtualRetainRelease(int value) : value(value) {}

virtual void doRetainVirtual() const { refCount++; }
virtual void doReleaseVirtual() const { refCount--; }
virtual void doRetainVirtual() const { refCount++; calledBase = true; }
virtual void doReleaseVirtual() const { refCount--; calledBase = true; }
virtual ~VirtualRetainRelease() = default;
} SWIFT_SHARED_REFERENCE(.doRetainVirtual, .doReleaseVirtual);

struct DerivedVirtualRetainRelease : VirtualRetainRelease {
DerivedVirtualRetainRelease(int value) : VirtualRetainRelease(value) {}

mutable bool calledDerived = false;
void doRetainVirtual() const override { refCount++; calledDerived = true; }
void doRetainVirtual() const override { refCount++; }
void doReleaseVirtual() const override { refCount--; }
};

Expand Down
4 changes: 3 additions & 1 deletion test/Interop/Cxx/foreign-reference/lifetime-operation-methods.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
// RUN: %target-run-simple-swift(-I %S/Inputs -cxx-interoperability-mode=upcoming-swift -I %swift_src_root/lib/ClangImporter/SwiftBridging -Xfrontend -disable-availability-checking)

// REQUIRES: executable_test

// Temporarily disable when running with an older runtime (rdar://128681137)
// UNSUPPORTED: use_os_stdlib
// UNSUPPORTED: back_deployment_runtime
Expand Down Expand Up @@ -61,7 +63,7 @@ LifetimeMethodsTestSuite.test("virtual retain/release") {
LifetimeMethodsTestSuite.test("overridden virtual retain/release") {
let a = DerivedVirtualRetainRelease(456)
expectEqual(a.value, 456)
expectTrue(a.calledDerived)
expectFalse(a.calledBase) // in optimized builds, we might not call retain/release at all
expectTrue(a.refCount > 0)
expectTrue(a.refCount < 10) // optimizations would affect the exact number
}
Expand Down