[Test][Concurrency] Convert VAR=value to env VAR=value for Lit shell #84566
+17
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…internal shell Convert `VAR=value cmd` to `env VAR=value cmd` in Concurrency tests for compatibility with LLVM Lit’s internal shell. Partially address swiftlang#84407
hnrklssn
requested changes
Sep 30, 2025
| // RUN: %target-build-swift -target %target-swift-5.1-abi-triple -parse-as-library %s -o %t/a.out | ||
| // RUN: %target-codesign %t/a.out | ||
| // RUN: %env-SWIFT_IS_CURRENT_EXECUTOR_LEGACY_MODE_OVERRIDE=legacy %target-run %t/a.out | ||
| // RUN: env SWIFT_IS_CURRENT_EXECUTOR_LEGACY_MODE_OVERRIDE=legacy %target-run %t/a.out |
There was a problem hiding this comment.
The %env- here is replaced by lit with this substitution rule in test/lit.cfg (substitutions generally start with %):
# Different OS's require different prefixes for the environment variables to be
# propagated to the calling contexts.
# In order to make tests OS-agnostic, names of environment variables should be
# prefixed with `%env-`, which is then expanded to the appropriate prefix.
config.substitutions.append(('%env-', config.target_env_prefix))
We still want this expansion to occur, so that env vars use the appropriate prefix for the relevant context. Could you instead change it to be env %env-SWIFT_IS_CURRENT_EXECUTOR_LEGACY_MODE_OVERRIDE=legacy %target-run %t/a.out?
|
@swift-ci please smoke test |
hnrklssn
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert
VAR=value cmdtoenv VAR=value cmdin Concurrency tests for compatibility with LLVM Lit’s internal shell.Partially address #84407