Fix malformed AST with property or subscript returning dynamic Self on an opened existential #84594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ials are involved This worked for functions, but for properties, we did things in the wrong order. Fixes rdar://160816868.
slavapestov
requested review from
hborla,
jckarter and
xedin
as code owners
jckarter
approved these changes
Sep 30, 2025
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
slavapestov
force-pushed
the
fix-rdar160816868
branch
from
545e2c1 to
8615409
Compare
slavapestov
requested review from
bnbarham,
hamishknight and
rintaro
as code owners
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
Fixes rdar://161588385.
slavapestov
force-pushed
the
fix-rdar160816868
branch
from
8615409 to
5be227a
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
|
@swift-ci Please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This worked for functions, but for properties and subscripts, there was a long-standing bug where we did things in the wrong order.
There is some duplicated logic between buildVarMember() and buildSubscriptHelper() in CSApply that is now even more apparent. At some point we should try to consolidate this to prevent such issues from appearing again in the future.
Fixes rdar://160816868 and rdar://161588385.