[sil-llvm-gen] Run Sema before we attempt to emit IR. #84622
Merged
+9
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
|
Forgot this depends on requestifying import resolution |
gottesmm
force-pushed
the
pr-7065a633780e3a54b56563650e321ec0801bcb45
branch
from
a9f5581 to
3a96e99
Compare
|
@swift-ci smoke test |
|
I was originally going to obviate this by requestifying importing... but I found that it triggered some sort of side-effect in SwiftDriver that I was unable to reproduce locally. I do not have time to debug this, so I am just going to go with this option since it will get what I actually need done and let me make progress. |
|
@swift-ci test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small thing I noticed as I was making improvements here.