[VariadicGenerics] Fix memeffect of metadata accessor. #84635
Merged
+19
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The metadata accessor for a variadic generic type takes as arguments packs of metadata records and witness tables, and each such pack is passed in a buffer. So any such accessor is not correctly annotated `memory(none)`. rdar://161606892
|
@swift-ci please test |
|
@swift-ci please apple silicon benchmark |
|
@swift-ci please test source compatibility |
|
@swift-ci please test windows platform |
|
Source compatibility failures match failures in baseline: https://ci.swift.org/job/swift-main-source-compat-suite/1254/consoleText . |
rjmccall
approved these changes
Oct 3, 2025
nate-chandler
added a commit
to nate-chandler/swift
that referenced
this pull request
Oct 3, 2025
Follow up to swiftlang#84635. The metadata accessor for a variadic generic type takes as arguments packs of metadata records and witness tables, and each such pack is passed in a buffer. So the call to any such accessor is not correctly annotated memory(none). rdar://161606892
nate-chandler
added a commit
to nate-chandler/swift
that referenced
this pull request
Oct 3, 2025
Follow up to swiftlang#84635. The metadata accessor for a variadic generic type takes as arguments packs of metadata records and witness tables, and each such pack is passed in a buffer. So the call to any such accessor is not correctly annotated memory(none). rdar://161606892
nate-chandler
added a commit
to nate-chandler/swift
that referenced
this pull request
Oct 8, 2025
Follow up to swiftlang#84635. The metadata accessor for a variadic generic type takes as arguments packs of metadata records and witness tables, and each such pack is passed in a buffer. So the call to any such accessor is not correctly annotated memory(none). rdar://161606892
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metadata accessor for a variadic generic type takes as arguments packs of metadata records and witness tables, and each such pack is passed in a buffer. So any such accessor is not correctly annotated
memory(none).rdar://161606892