[test] Add requires for embedded_stdlib for test that uses the stdlib #84656
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test enables the Embedded experimental feature, but beside the compiler support, it also requires loading the stdlib for embedded, but the test is not marked as such. For configurations that do not build the embedded stdlibs, this makes the test fail, because the stdlib is not available. Mark it with the appropriate requires to avoid this problem. This should not change the results in the swift.org CI because those CI configurations build the embedded stdlibs by default.
|
@swift-ci please smoke test |
|
@nate-chandler I wonder if the crash only was reproducing when using |
|
Yes, the crash was only reproducing with that. Thank you for adding the line. |
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test enables the Embedded experimental feature, but beside the compiler support, it also requires loading the stdlib for embedded, but the test is not marked as such. For configurations that do not build the embedded stdlibs, this makes the test fail, because the stdlib is not available. Mark it with the appropriate requires to avoid this problem.
This should not change the results in the swift.org CI because those CI configurations build the embedded stdlibs by default.