[test] Mark test as UNSUPPORTED when maccatalyst_support is enabled #84657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If one tries to enable maccatalyst_support (which doesn't work correctly, see swiftlang#77506), this test fails because `Swift.swiftmodule` gets generated with both `-target` and `-target-variant` `swift-module-flags`, which triggers the usage of the `isOSVersionAtLeastOrVariantAtLeast` version of version check, which does not match the test `CHECK` lines. Mark the test as `UNSUPPORTED` when the feature is enabled. Not sure if the test can be rewritten conditionally on a feature being support and checking for different functions in the IR. This should not affect swift.org CI because that CI never enables maccatalyst_support.
|
@swift-ci please test |
|
@swift-ci please test macOS platform |
|
@swift-ci please test Windows platform |
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one tries to enable maccatalyst_support (which doesn't work correctly, see #77506), this test fails because
Swift.swiftmodulegets generated with both-targetand-target-variantswift-module-flags, which triggers the usage of theisOSVersionAtLeastOrVariantAtLeastversion of version check, which does not match the testCHECKlines.Mark the test as
UNSUPPORTEDwhen the feature is enabled. Not sure if the test can be rewritten conditionally on a feature being support and checking for different functions in the IR.This should not affect swift.org CI because that CI never enables maccatalyst_support.