[Embedded] Identify more places to emit symbols even with deferred code generation #84682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tation @c @implementation relies on matching the original C declaration. The lookup for the original C declaration was doing the wrong kind of lookup, meaning that it could only find the C declaration if it came through a bridging header, and not through a normal module import. Using unqualified lookup here finds the name appropriately. Clarify the diagnostics here as well to not talk about umbrella and bridging headers. Fixes rdar://161909754.
…de generation Deferred code generation only produces symbols when they are needed. Expand this out to cover more of the cases where we need them: * @c/@_cdecl with and without @implementation * @_expose(Cxx) and @_expose(Wasm) * @_section and @_used * (already present) the main entry point Part of the Embedded Swift linkage model. Also fixes swiftlang#74328 / rdar://147207945 along the way.
DougGregor
requested review from
hborla,
slavapestov,
jckarter,
zoecarver,
egorzhdan,
beccadax,
ian-twilightcoder,
Xazax-hun,
j-hui,
fahadnayyar,
susmonteiro and
xedin
as code owners
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux |
|
@swift-ci please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deferred code generation only produces symbols when they are needed.
Expand this out to cover more of the cases where we need them:
Part of the Embedded Swift linkage model. Also fixes #74328 /
rdar://147207945 along the way.