[Sema] Reject tuple extensions early when feature is disabled #84694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tuple extensions are still an experimental feature, but we have a number of crashers in the repo for them because we still use their type-checker machinery even when disabled. Change the logic here such that we reject them early in extension binding when the feature is disabled. This will ensure we address the crashers before productizing.
hamishknight
requested review from
bnbarham,
hborla,
rintaro,
slavapestov and
xedin
as code owners
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
AnthonyLatsis
approved these changes
Oct 5, 2025
|
@swift-ci please smoke test macOS |
|
macOS failure is unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tuple extensions are still an experimental feature, but we have a number of crashers in the repo for them because we still use their type-checker machinery even when disabled. Change the logic here such that we reject them early in extension binding when the feature is disabled. This will ensure we address the crashers before productizing.