RequirementMachine: Diagnose unsupported value generic parameter definitions properly #84730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyLatsis
requested review from
hborla,
slavapestov and
xedin
as code owners
AnthonyLatsis
force-pushed
the
jepa-main2
branch
from
fa98843 to
25e19e8
Compare
AnthonyLatsis
commented
Oct 7, 2025
|
@swift-ci please smoke test |
…nitions properly The flow was such that we recorded subtype constraints regardless of the subject type's nature. Extract value generics handling out of the devious `else if` chain, and never record any subtype constraints if the subject type is a non-type parameter. While we're here, generalize the diagnostic message for user-written subtype constraints on value generic parameters and emit it consistently, not just if the right-hand side contains a protocol type.
AnthonyLatsis
force-pushed
the
jepa-main2
branch
from
25e19e8 to
58fa8bf
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test Windows |
|
@swift-ci please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flow was such that we recorded subtype constraints regardless of the subject type's nature. Extract value generics handling out of the devious
else ifchain, and never record any subtype constraints if the subject type is a non-type parameter.While we're here, generalize the diagnostic message for user-written subtype constraints on value generic parameters and emit it consistently, not just if the right-hand side contains a protocol type.