OpaqueValues: support typed throws #84734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use a direct @error emission style when opaque values is enabled, relying on AddressLowering to satisfy the formal @error_indirect convention.
|
@swift-ci smoke test |
Out of SILGen, we'll get the non-indirect SSA for throwing the error. AddressLowering then converts a `throw` into `throw_addr` to match the function convention. Similarly, a try_apply gets rewritten to pass the error address to the error successor block. resolves rdar://158171053
kavon
force-pushed
the
opaque-values/fixes-2
branch
from
2eead0a to
37eafa9
Compare
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Out of SILGen, we'll get the non-indirect SSA for throwing
the error. AddressLowering then converts a
throwintothrow_addrto match the function convention. Similarly, atry_apply gets rewritten to pass the error address to the
error successor block.
resolves rdar://158171053
TODOs