[Mangling] Provide signature for param'd types. #84736
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a type is appended to the mangling, if that type has a type parameter, provide the relevant generic signature with it. rdar://161968922
|
@swift-ci please smoke test |
nate-chandler
commented
Oct 7, 2025
| auto canTy = substTy->getCanonicalType(); | ||
| appendType(canTy, nullptr); | ||
|
|
||
| GenericSignature signature; |
There was a problem hiding this comment.
@slavapestov Is there a better way to obtain this† signature?
† Or the one this ought to be.
There was a problem hiding this comment.
I have no idea what this function is doing, but calling GenericSignature::get() directly with a bunch of random requirements is unlikely to be meaningful.
There was a problem hiding this comment.
It looks like the given sig is the generic signature of the callee. We also need to pass down the generic signature of the caller.
There was a problem hiding this comment.
I couldn't figure out a nice way to plumb this down. GenericSpecializationMangler is a tangled mess. This should work though: #84765
nate-chandler
requested review from
slavapestov
and removed request for
eeckstein and
jckarter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a type is appended to the mangling, if that type has a type parameter, provide the relevant generic signature with it.
rdar://161968922