LifetimeDependenceDefUseWalker: store to unsafeMutableAddress #84739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atrick
requested review from
eeckstein,
hborla,
jckarter,
slavapestov and
xedin
as code owners
|
@swift-ci test |
atrick
force-pushed
the
lifedep-unsafeaddress
branch
from
83386ca to
f2c1a91
Compare
Handle storing to a mutable property implemented as unsafeMutableAddress. In SIL, the stored address comes from pointer_to_address. Recognize the addressor pattern and handle the store as if it writes to a regular property of 'self'. Required for UnsafePointer<~Escapable>.pointee.
atrick
force-pushed
the
lifedep-unsafeaddress
branch
from
f2c1a91 to
4378995
Compare
|
@swift-ci test |
|
@swift-ci smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SwiftCompilerSources: bridge Type.unsafePointerElementType
SwiftCompilerSources: bridge Function.isAddressor()
LifetimeDependenceDefUseWalker: store to unsafeMutableAddress
Handle storing to a mutable property implemented as unsafeMutableAddress. In
SIL, the stored address comes from pointer_to_address. Recognize the addressor
pattern and handle the store as if it writes to a regular property of 'self'.
Required for UnsafePointer<~Escapable>.pointee.
Unit tests are PR: #84233